QR-Code solution

Community feedback

• 

  Adeola Ganiu•1,320

  @Deolabest

  Posted almost 3 years ago

  Hey @stwslim83, Congratulations on completing this challenge!

  Here is my feedback:

  • Don't use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings.

  Keep doing a good job!

  11

  Marked as helpful
• 

  Ahmed•430

  @AhmedLebda

  Posted almost 3 years ago

  Hi @stwslim83, congrats on completing this one

  • You can use <main> instead of <div> to improve the accessibility of your page.
  • Adding max-width: 1440px and min-width: 375px to the body element won't make the content centered properly in screens larger than 1440px or lower than 375px , you can remove those styles and replace it with a margin: 20px for the wrapper div to avoid card touching screen edges in smaller screens

  00

  Marked as helpful
• 

  Adeola Ganiu•1,320

  @Deolabest

  Posted almost 3 years ago

  I forgot to add this:

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  01

  Marked as helpful