PhoenixDev22• 16,990
@PhoenixDev22
Posted
Hi Harsh Kumar,
Congratulation on completing your first frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- Use the
<footer>for the attribution, it should live outside the<main>. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentornot describes the image. The alternate text should not hyphenated , it should be human readable.
- In order to center the card on the middle of the page , you can use the flexbox properties and
min-height: 100vhfor the<body>add a little padding to the body that way it stops the card from hitting the edges of the browser. Then you can remove .card-top margin.
width: 300px;an explicit width is not a good way to have responsive layout . consider usingmax-widthto the card inreminstead .
- Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
- Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
- Using percentages for widths, using max-width and avoiding to set heights for the components, with these things is the key to mastering responsive layouts.
Last , It's a good practice to have the styles in separate file he reason for this is that the CSS stylesheet exists for the purpose of defining the presentation style of the document. The HTML file exists to define the structure and content of the document also it's useful If multiple pages on your site have the same look and feel.
Overall, Your solution is good. Hopefully this feedback helps.
1
Harsh Kumar• 1,390
@thisisharsh7
Posted
@PhoenixDev22 Thanks a lot! In my next challenge I will built my project by keeping all this point in my mind. Thanks again !!
0
