qr_code_component

Hi @mlevrat 👋, good job completing this challenge! 🎉

I like this solution for the challenge. I have some suggestions you might consider to improve your code:

• Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

• The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.

• To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

• Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

I hope those tips will help you! 👍

Good job, and happy coding! 😁

Hey @mlevrat, Congratulations on completing this challenge!

Here is my feedback:

• It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

• Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

Keep doing a good job!