Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

QR-code-component

Chibuzor victor•40
@Vsimdy
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Hassia Issah•50,390
    @Hassiai
    Posted about 2 years ago

    Replace <div class="container"> with the main tag and <h3> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

    Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

    To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

    Give .text-container a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

    There is no need for a margin value in .container.

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
  • Boluwatife Bonaventure•660
    @Boyutife
    Posted about 2 years ago

    Hi ​Chibuzor victor 👋. Congratulations on successfully completing the challenge! 🎉

    Great work on your markup so far! I have few suggestions that could further improve the structure and design of your webpage.

    HTML:🔖🔖🔖

    • Great job on using the h3 tag in your content! I wanted to offer a suggestion that could help improve the accessibility of your page.

    • My suggestion is to consider using an h1 tag as your main heading, followed by h2 and h3 tags as needed to organize your content. This will help improve the accessibility and usability of your page for all users.In general, it's a good idea to use only one h1 tag on each page, followed by h2 and h3 tags to organize your content. This is because using an h1 tag as the main heading on your page can improve accessibility and make it easier for users to navigate your content.

    • This will not only help with accessibility, but also make it easier for search engines to understand the structure of your page.

    • Also, instead of using a div tag to wrap your content, you might consider using a main tag, which is more semantically appropriate for indicating the primary content of your webpage. In conclusion, to make your design more centralized and compact, you might consider setting a max-height and max-width property for your main container. This can help ensure that your content is displayed in a consistent and visually appealing manner, especially on smaller screens.

    STYLE: 🎨🎨

    You considering using relative units like em and rem rather than fixed units like px for your styling because of the following :

    • Accessibility: Using relative units can improve accessibility for users who may need to increase the font size or zoom in on a web page. With relative units, the font and layout will adjust accordingly, making it easier for users to read and interact with the content. Responsive design: Relative units can also make your design more responsive, as they allow your layout to adapt to different screen sizes and device types. This can be especially important for mobile devices, where screen sizes can vary significantly.

    • Consistency: Relative units can help maintain consistency across your design, as they ensure that fonts and layout elements are sized in proportion to each other. This can make your design look more polished and professional. Scalability: Finally, using relative units can make your code more scalable and easier to maintain, as changes to font or layout sizes can be made in one place and affect the entire design.

    I hope these suggestions are helpful and will lead to an even better final product. Let me know if you have any further questions or need additional assistance!

    HAPPY CODING

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub