Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component

Aldi Joko 410

@aldijoko

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul 8,560

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. .

Here are my suggestions..

  • You should use <main class="card"> instead of <div class="card">.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.

This should fix most of your accessibility issues

. Regardless you did amazing... hope you find this useful... Happy coding!!!

Marked as helpful

1

Aldi Joko 410

@aldijoko

Posted

@Samadeen thank you for the advice, its very helpful for me to improve my skill as frontend

1
Sharif 90

@sharif-22

Posted

bro you can center the card section by giving margin-top: 15%; in your card class any way your answer is good 👍😊

Marked as helpful

0

Aldi Joko 410

@aldijoko

Posted

@sharif-22 thank you so much bro, finally i can fix this card to bring into the center

0
Sharif 90

@sharif-22

Posted

@aldijoko lets commit it and generate new screenshot

it will display yours new solution ❤🍻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord