Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component-challenge-hub

#accessibility

@nicolasgonzalez98

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Rio Cantre 9,710

@RioCantre

Posted

Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…

  • Import the attribution style in CSS file and remove the style tag. If not used, remove it completely.
  • Wrap the whole content with specific tag like main. For HTML structures, refer it with this one Semantics
  • Clean the whitespaces in the code
  • In the .main rule set, adjust padding into padding: 1rem; and border-radius: 20px;. Adjust the width into width: 310px;, remove height: 60vh;
  • Adjust the following properties into background-size: cover; and border-radius: 20px; in the .qr rule set. Set a fix size into height: 300px; and width: 300px;
  • Add text-align: center; in .texto p rule set
  • Adjust the font size in .texto h1 rule set into 21px

Above all, Well done! Keep it up and Hope this is helpful!

Marked as helpful

0

Hexer 3,680

@Phalcin

Posted

Great work overall man.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord