Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

qr-code-component-main

tariqyunusa•70
@tariqyunusa
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Agnik Bakshi•480
    @Agnik7
    Posted over 2 years ago

    Hi, Congratulations on completing the challenge. I have some tips that might be of help to you.

    • You are using the relative path in the src of the img tag. You have mentioned the path as /qr-code-component-main/image-qr-code.png. However, for any element present inside a secondary folder within the root folder, the path starts with ./. So, your correct path should be ./qr-code-component-main/image-qr-code.png . Always give an alt text, which specifies what to show if for any reason the image can't be displayed. Replace your img tag with the following. <img src="./qr-code-component-main/image-qr-code.png" alt="QR code image" />

    • Replace the h3 tag by the h1 tag. Always start from h1 and keep on decreasing one level. This will help prevent accessibility issues.

    • Wrap the whole content in the body of the html inside main tag. To learn more about accessibility and semantic html, click here.

    • In the index.html file, you are not using the style tag, so it's better to remove it. This helps you keep only the necessary lines of code.

    • While centering in the body, instead of height, define the min-height for better responsiveness. You don't need to add width:100% since, 100% of the width is taken by default if nothing is mentioned.

    • Define the max-width of the container, instead of the width to make it more responsive.

    Hope this feedback helps you to improve in the future. Have a nice day!!

  • Mr Rabbit•1,020
    @rabbitmaid
    Posted over 2 years ago

    You seem to have an issue with the display of your image. Currently this is what you did

    <img src="/qr-code-component-main/image-qr-code.png" alt="">
    

    You can replace the code above with this

    <img src="qr-code-component-main/image-qr-code.png" alt="Short Image Description"> The reason why the image does not due to the incorrect path. Though the path you used might be seen by some code editors, it will not be visible on the browser. Simply remove the slash at the beginning an the image will load.

    -Also all Images in your design should always have the alt attribute. This helps search engines easily understand what the image is all about.

    • HTML5 elements such as <main>, <nav>, <header>, <footer>, <section>, <aside> act as landmarks, or special regions on the page to which screen readers and other assistive technologies can jump. By using landmark elements, you can dramatically improve the navigation experience on your site for users of assistive technology (Users with disabilities) .

    You can use the <div> for sub items within landmarks like <section>. In other words for containers or sections in your html you can use the <section> tag.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub