Looking to hire developers?
I don't have a particular question on this project but I would be grateful for any suggestions that can make me improve
@maqsudtolipov
Posted
Hi there 👋
Congratulate on finishing your project 🎉. You did a great job 💡
I give some suggestions to help you take your project design to the next level 📈😉
.container. In CSS adding height is not good practice until you really need it ⚠. If you remove it from the container it still works and nothing changes, because the height calculated automaticallyHappy coding ☕
Maqsud
Marked as helpful
@caio-alcantara
Posted
You did a great job! But why didn't use the * selector to remove all the default margin/padding?
Marked as helpful
@Christ-Kevin
Posted
@caio-alcantara honestly i copied it in this codepen(https://codepen.io/pen?&editors=110&layout=left) from smolcss(https://smolcss.dev/).
But I understand your point and I think it's a good idea to use the global(*) selector. I will try this for sure in my next projects.
Thanks
@NaveenGumaste
Posted
hay! Christ Kevin Touga Watat Nice work
@gomesemog
Posted
Great job my friend! I would second Caio's comment, its very useful. Other thing that I would point is that you centralized all the content, but it should be attribuited just for the card itself. Otherwise, again, great job!
@optimusprime202
Posted
Hey @Christ-Kevin, Tremendous work!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
