QRCode_FrontendMentorChallenge

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Kenzar, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • the image is broken because the url is wrong, fix like this: <img alt="" src="./images/image-qr-code.png">
  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from container class because with flex they are superfluous
  • add justify-content: center flexbox property to the body to center the card horizontally
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  01

  Marked as helpful
• 

  Andy•520

  @AndyAshley

  Posted over 3 years ago

  Hey Kenzar, good job on the challenge! I found your issue with the image. When I go to inspect the page and add a . in front of your image path everything works fine :) .

  You have /images/image-qr-code.png . Just change it to ./images/image-qr-code.png , or remove the / altogether, and it will pop right up. It couldnt find the path within the folder hierarchy. Check out w3 Schools HTML File Paths

  You can also clear up the Accessibility issues by wrapping your content within the body in a <main> tag or other appropriate landmark tag. For the <h1> issue, throw your main header text into an <h1> instead of an <h2> tag. You can style this to reduce the font size if you need to. Happy coding and hope that helps!

  01

  Marked as helpful