Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Qr-code-project-using-CSS-and-HTML

Ojas Dubey•20
@ojninja16
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am not sure why my name is not being displayed within the same line as "Challenge by Frontend Mentor Coded by" ...... Thanks for help....

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul•8,560
    @Samadeen
    Posted about 3 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Here are my suggestions..

    • You should use <main class="imgmain"> instead of <div class="imgmain">.
    • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
    • You left a h1 empty in your HTML markup.. Kindly review that and you are set to go.

    This should fix most of your accessibility issues and HTML issues

    . Regardless you did amazing... hope you find this useful... Happy coding!!!

    Marked as helpful
  • P
    Marge C.•440
    @msunji
    Posted about 3 years ago

    Hey there! Great job solving this challenge 👏

    Instead of using multiple <br /> tags to create space between elements, you could try setting a bottom margin instead. It'll clean up your code a bit and you'll have a bit more control over the amount of spacing you want between elements.

    Hope this suggestion helps and good luck with the next challenges!

    Marked as helpful
  • Yehan Nilanga•670
    @Yehan20
    Posted about 3 years ago

    Hey Congratulations for completing the challenge , your name is not displaying in the same line because there isn't enough space for it to display within one line it may be because of padding or the width of the card , try to increase the width a bit and try , also try to fix the html and accessibility issues to improve the solution , i hope my feedback was helpful, good luck for the next challenges.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub