Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Random advice generator using API call and Sass

#bem#sass/scss

@jaycgreenwald

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was my first API call. I don't have any specific questions, but I would love it if you reviewed my code and provided any feedback on ways I might improve the next project. Thank you so much. Cheers!

Community feedback

Eduardo 200

@EDDuardOo-Code

Posted

Congratulations completing your first challenge with an API

The result it is really good, the async function works pretty well and the desing it is responsive also i like that you use Sass, and also make each part of the function wait to get the response,

If there is something that i would point out, would be the lack of a background shadow, and maybe , that you don't put your js in a folder, but those are minor details ,

Overall the desing and funcionability of your app it is amazing, keep the good work Hope to some more of your publications

Marked as helpful

1

@jaycgreenwald

Posted

@EDDuardOo-Code Thank you for the feedback. I'll go back and look at the shadow issue and see if I can correct that. As for the JS file, I've been learning bits and pieces about how to organize files/folders so I'll look into where to tuck it for future projects. Thanks again!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord