Random advice generator with data gotten from an api

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Your solution generates accessibility error reports due to non-semantic markup

  ---

  • So fix it by replacing the <div class="container"> with semantic element <main> to improve accessibility and organization of your page.

  ---

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections

  ---

  CSS 🎨:

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📙.

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  
      margin: 0;
  }
  

  ---

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  00

  Marked as helpful