Rating app

Community feedback

• 

  Matias Ludueña•1,990

  @matiasluduena23

  Posted over 1 year ago

  Hi SUBHI-05’S! Congratulations you finished the challenge! Just one recommendation that might help you.

  • try to write all you Javascript code in your JS file, is more clean and easy to debbug. Maybe you can get all your rating-item and look for a click to apply the class active and remove for the other ranting elements. Something like this:

  const allRatingItem = document.querySelectorAll('.rating-item');
  
  allRatingItem.forEach((item) => {
       item.addEventListener('click', (e) => {
         removeClass();   
         item.classList.add("rating-item-clicked")
       })
  })
  
  function removeClass(){
      allRatingItem.forEach((item) => {
          item.classList.remove("rating-item-clicked")
      })
  }
  

  • A good practice is to be more modular, a function only has to do one thing. Hope this help you!

  Good code!

  Matias

  11

  Marked as helpful