
Solution retrospective
- Should I use less HTML syntax when using React.js? I used a few divs when setting up my Main.js files and was wondering if I should get used to using components instead?
- Let me know if you have any tips/suggestions or find any spotted bugs, thanks!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @pikapikamart
Hey, awesome work on this one. Layout in desktop looks great , it is responsive but on mobile view.. Nevermind, the image was just loading for a while that is why I thought that you forgot to include the image.
Yes and why won't you use html syntax? or are you referring to something? Also, your component on this are fine. If I would do it:
<main> <Hero /> # or not hero since it is not a full layout <Accordions /> </main>
We can also make each accordion a separate component as well.
- On the accordions, what you should have done is that, nest the
button
and the answer in one parent:
parent button answer
this way they are isolated enough. Also on the
button
use aaria-expanded="false"
as a default attribute then set it totrue
if the user toggles it. You can use that as a styling hook so that you won't have to check if button was clicked to trigger thep
tag. This way for seo, it is friendly (but not as an spa in react) then you could just:button[aria-expanded="true"] + p { show the p tag }
- Lastly, if you remove the
outline
property of an element, make sure to add another custom visual indicator on the element's:focus-visible
state. Try using tab on your keyboard to navigate the site, you will have a hard time since there is no indication on where you at.
Aside from those, great work again on this one.
Marked as helpful - On the accordions, what you should have done is that, nest the
- @CyrusKabir
hello my dear friend ♥ you did very good and clean but you forget to add hover state on question title ( soft red in hover mode ) and also I try this challenge too and I will be very happy to see my solution not just happy also for problem fixing and advice from you :) ♥
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord