Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

React and CSS

Carlos•1,110
@Carlos-A-P
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


  • Should I use less HTML syntax when using React.js? I used a few divs when setting up my Main.js files and was wondering if I should get used to using components instead?
  • Let me know if you have any tips/suggestions or find any spotted bugs, thanks!
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted almost 4 years ago

    Hey, awesome work on this one. Layout in desktop looks great , it is responsive but on mobile view.. Nevermind, the image was just loading for a while that is why I thought that you forgot to include the image.

    Yes and why won't you use html syntax? or are you referring to something? Also, your component on this are fine. If I would do it:

    <main>
      <Hero /> # or not hero since it is not a full layout
      <Accordions />
    </main>
    

    We can also make each accordion a separate component as well.

    • On the accordions, what you should have done is that, nest the button and the answer in one parent:
    parent
      button
      answer
    

    this way they are isolated enough. Also on the button use a aria-expanded="false" as a default attribute then set it to true if the user toggles it. You can use that as a styling hook so that you won't have to check if button was clicked to trigger the p tag. This way for seo, it is friendly (but not as an spa in react) then you could just:

    button[aria-expanded="true"] + p {
      show the p tag
    }
    
    • Lastly, if you remove the outline property of an element, make sure to add another custom visual indicator on the element's :focus-visible state. Try using tab on your keyboard to navigate the site, you will have a hard time since there is no indication on where you at.

    Aside from those, great work again on this one.

    Marked as helpful
  • CyrusKabir•1,885
    @CyrusKabir
    Posted almost 4 years ago

    hello my dear friend ♥ you did very good and clean but you forget to add hover state on question title ( soft red in hover mode ) and also I try this challenge too and I will be very happy to see my solution not just happy also for problem fixing and advice from you :) ♥

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub