Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

React App. Not mobile compatible yet. Some queries on paddings.

react
Paras Sharma•700
@imparassharma
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I use rems pretty much and recently I read somewhere that rems should not be used for paddings and margins. Can anyone look into my code and can tell me the drawbacks of using rems in the given solution and what alternative I can use so to make it more responsive. Any other feedback is also welcome.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ngouend raoul Gerard•680
    @BeinRain06
    Posted almost 2 years ago

    Your are welcome, @imparassharma You can link css file in your main.js file of react not do an inline-css. Here above is what I'm suggesting :

    create a file called style.css in the same directory that your main.js file

    Add some style in this css file. Now to link it to your main.js file: --> open your main.js* file and Write this line at the top :

    import "./style.css"
    

    And see if it works to implement your style written on this later file.

    Hope that make sense if some issue appears again could leave me some brief explanation I will try to lead my answer through the best I could. Having this nice journey, I'm just keep saying happy coding to you @imparassharma

    Marked as helpful
  • Ngouend raoul Gerard•680
    @BeinRain06
    Posted almost 2 years ago

    Hello @imparassharma I have seen your mobile app. But what I wondering why, you didn't use style.css file to style the whole main.js file

    But my quick way to see to correct each section is in mobile to stack the section Stay updated over the section with big image.

    For e.g I think you might do something like that :

    <div class="general_wrapper">
    
          <div class="section-one padding-effect">
    
            <div class = "content-section-one">
              ... // some syntax section one
            </div>
         </div>
         <div class="section-two padding-effect">
           <div class = "content-section-two">
            ... // some syntax section two
           </div>
          </div>
    

    And in style.css try this along or either with your javacsript code:

    .general_wrapper {
    
       width: 100vw;
             ... 
    }
    
    .padding-effect {
       width: calc (100%  - 1em)
       margin: 0 auto;
         ... 
       
      }
    

    To make the padding of 1em each time in mobile. Instead using rem units you might use em units in mobile but not in desktop because it become quite large due to the fact that em unit is calculated according to the direct parent element with that grows bigger in desktop style.

    Hope you might have a solution to fix the displaying, and also have a nice day /night@imparassharma

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub