React App styling SASS and flexbox

Solution retrospective
This is my first challenges here in frontend mentor! Enjoyed translating design to code.
Practicing my react and styling at the same time. So I made it render using json data file I plotted.
Any advice on my journey? Thanks! 🎄☃️Happy Holidays Everybody!☃️🎄
Please log in to post a comment
Log in with GitHubCommunity feedback
- @inanocs
Great job! the dark mode transition is smooth and good!
- @abhik-b
Hi Mervin 👋, Your solution is absolutely perfect 👏
I liked the hover state for any of the platforms, it looks responsive and overall theme transition is great. I looked at your code and it is well written.
Just a opinion I wanted to share -
const icons
&const toK
are written and required in both the Platform and PlatformBottom files- Please make another file and export
const icons
&const toK
from there and import and use them on both the Platform and PlatformBottom files - this will avoid code duplication and in any case you update any of the const , the change will be available for both the components(Platform and PlatformBottom)
But that was just a opinion I had as I did not understand why you have written them in both places.
Great job, Keep contributing your amazing solutions 🚀
- @ApplePieGiraffe
Hey, iMervinC! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉 Good work on this one! I like the fluid transition of the little circle in the toggle-switch! 😀
I suggest,
- Making the toggle-switch tabbable so that keyboard users can access and use the toggle-switch.
- Clearing up your solution report by removing one or two duplicate IDs found on the page. 😉
Keep coding (and happy coding, too)! 😁
And happy holidays! 🎄
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord