React, bootstrap, css , vite, js.

Community feedback

• 

  P

  visualdennis•8,375

  @visualdenniss

  Posted over 2 years ago

  Hey there,

  Great work. your solution looks good overall and seems to be working. However, i've checked the code and seems like you are using too many states. It it possible to reduce it to only one state, or even less. Also the way it is structured right now, seem too hard-coded, meaning if the data and values do changes or gets added, your app would run into problems scaling and you would need to come and update the source code. Try to use dynamic values whenever possible.

  E.g. you could have an array of objects, where each object contains data for individual notification, and you could render card-notification component for each using map() function. After all, main point of React is to make your whole app and components as reusable as possible.

  You can also check out my submission for this exact challenge, as i've also done it in React JS, so it might give you some ideas.

  Hope you find this feedback helpful!

  01

  Marked as helpful