Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

React JS and Style Components

Nabil•160
@Nabil19911
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hey fellow developers, please review and give feedback. Thank you in advance.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alex•2,010
    @AlexKMarshall
    Posted over 3 years ago

    Looks good on desktop, it's laid out nicely. It could do with some work on mobile though, the spacing is off, you're missing a lot of padding.

    Edit: I see you've fixed the mobile spacing since I wrote this, so that's looking better now.

    I'd avoid using margin for spacing now. Flex gap is supported in all major browsers and is a more robust choice for laying out each of the component sections.

    You've got some specified widths in there, like 90%. I would again avoid that. Flex alignment and padding on the container should get you everything you need.

    For my personal taste there's too many separate components that makes the project hard to navigate. I would move the styled components into the same file as the component that they're styling, it makes it a lot easier to see what depends on what. I would try and reduce the number of wrapping divs here too. You can have one element for the main grid container. 3 elements inside that - one for each section, and then the content directly inside those.

    I'd probably do it all in one React Component too, there's no functionality here that makes separating out into multiple components worth-while, this reference is good: https://kentcdodds.com/blog/when-to-break-up-a-component-into-multiple-components

    Marked as helpful
  • Md Ajmal Shadab•410
    @mdajmalshadab
    Posted over 3 years ago

    Hey, nice work, everything is fine except the fact that the card is jumping a bit while changing the screen size and try increasing the length of the button shadow and add hovering color change on the button if possible. Happy Coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub