Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

React JS Game | styled-components | Framer Motion

Bonrey•1,130
@Bonrey
A solution to the Rock, Paper, Scissors game challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello, everyone!

This time, I decided to create something new: a simple game. Making it was fun, and I learned lots of stuff along the way, as always. Especially about the Framer Motion library! It turned out to be very useful.

Anyway, I still have a couple of questions for the community:

  • Is there a way to get rid of flickering images? I bet they are constantly preloading every time I refresh the site. And the whole experience isn't user-friendly at all. 😔
  • Should I avoid using nested styles in styled-components? And instead, try to create a separate Component for each element?

P.S. As regards the site functionality, I also added keyboard support:

  • "1", "2", "3": "Paper", "Scissors", "Rock" respectively;
  • "R": Show/Hide the rules popup;
  • "Esc": Hide the rules popup;
  • "Space"/"Enter": Play Again;
  • "Y": reset the score (else it is saved in your local storage);

As always, I would highly appreciate any feedback! 😃

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Rayane•1,935
    @RayaneBengaoui
    Posted about 4 years ago

    Hello Bonrey,

    Really nice to see you completing another challenge ! 🙂

    I think that you should avoid as much as possible nesting with Styled Components. While coding it might be quicker and simpler, but if the application scale or you decide to re-use components then you'll be happy to simply import them instead of copy pasting 😃.

    Otherwise, your project is super clean ! Really like how smooth you've made your animations and all the little details such as the keyboard accessibility, the reset button or even the growing circles around the winner !

    Have a nice day and happy coding ! 😃

  • Aderr0•55
    @Aderr0
    Posted about 4 years ago

    Yeah it's really good, I'm currently learning React.js and I will improve myself with your code :D

  • Borubar•115
    @Borub-ar
    Posted about 4 years ago

    (sorry for my bad English). Hi, it's awesome!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub