Hello, Bonrey! π
Good job on this one! Like ApplePieGiraffe well said the animations and popup are on point, it's nice touch. In my opinion this popup modal should pop up after user interact with input. So after clicking/focusing input it shoots. I believe that this is important information and often when something pops up right after entering the website, is to be turned off without reading. Additionally:
- Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
Good luck with that, have fun coding! πͺ
@Bonrey
Posted
Thank you, @tediko! You made a very good point about the popup. Actually, I just didn't know when and where to show it, so I just went with the easiest option. π
As for the accessibility concerns, I did want to add the outlines for anchors and buttons, but in the end, completely forgot about it. Thank you for pointing that out to me!