Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

React responsive countries api app

Moustafa Mahmoud•245
@DevMoustafa97
A solution to the REST Countries API with color theme switcher challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What is your opinion ? and any ideas about implementing dark mode? Thanks in advance :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted about 4 years ago

    Hey, great work on this. In terms of layout, the desktop is good and it resizes well when going in mobile state.

    Haven't tackled this challenge, so only for the UI:>

    • It will be better if you added some box-shadow so that the article will be contrasted well enough against the background.
    • Adding some focus state on the interactive elements will be awesome as well. So that users who prefers using keyboard to navigate will be easily accessing those. Also for the article, since the article itself is a link. You could make use of focus-within in this. So that when the focus is on the a tag inside the article, you could target the article to have some box-shadow or anything that will indicate that the user is in the element.

    Regarding your query. A simple way is that, when the dark mode is toggled, in your js, you add some class like dark-mode on the body tag. Then in your css, you can just make use of

    body.dark-mode {
        different declarations. 
        Target the different selectors that you want to be in dark-mode. 
        I don't know react but is css nesting allowed in it? 
    }
    

    This way, when the dark-mode is added, everything inside it will run.

    Overall, great job on this one^^

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub