Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

React Results Summary

react
DevMedic11•20
@DevMedic11
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


My solutions looks great on my end, and in the DevTools responsive test. But when i upload the solution the proportions look insane. COuld it be the way i set up my queries?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted about 2 years ago

    Hello there 👋. Good job on completing the challenge !

    • It seems like you might be repeating code in your media queries, you can create a media query for your responsive styles and adjust the specific properties that need to change based on the screen size.
    • Encourage adopting a mobile-first approach to build responsive solutions more efficiently. Start by styling for smaller screens first and then use media queries to add styles for larger screens.
    • Instead of using position: absolute for centering, consider using Flexbox. Wrap your component in a parent container and apply display: flex, justify-content: center, min-height: 100vh, and align-items: center to this parent. This will center your component both horizontally and vertically.
    • Avoid using viewport width units like width: 54vw; or min-width: 27vw; for your components. If the screen is very wide, your component will also become too large. Instead, use width: 100%; and set a max-width to restrict your component from growing beyond a certain width.
    • Instead of setting a fixed height with vh, allow the height to be determined by the content within the summary-container. By removing the explicit height, the container will adapt to its content and avoid potential issues with proportions on different screen sizes.

    I hope you find it useful! 😄

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub