Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

React + sass + flex

E.sa•300
@E-sa
A solution to the Todo app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I get "All page content should be contained by landmarks" warning. Any Idea how to fix it?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jayanth•190
    @gjaynir0508
    Posted almost 4 years ago

    Hi, I faced the same problem and found the solution in the following article.

    https://dequeuniversity.com/rules/axe/4.0/landmark-no-duplicate-main#:~:text=Rule%20Description%20It%20is%20a%20best%20practice%20to,the%20document%20has%20at%20most%20one%20main%20landmark.

    Hope this helps.

    Marked as helpful
  • Tesla_Ambassador•3,070
    @tesla-ambassador
    Posted almost 4 years ago

    Hey, this is a pretty awesome solution. I like it.

    1. if you want all page content to be contained within landmarks, you should make sure that all your "divs, image tags, buttons, forms... etc." are contained in landmarks like "Section, article, main, footer... etc." to enable people that are using screen readers to access your site.
    2. I think there's some sort of bug when I choose clear completed because it also clears those that I haven't marked as completed.
    3. Also make sure that all your "li" elements are contained within "ul" i.e. (<ul><li></li></ul> and on the same note, you can't have a div as a child element of an li.

    4.Make sure that you only have one main landmark. I recommend that you replace your second main landmark with a section or article. 5. Remember to add labels to form elements to help people that use screen readers to access your site. Otherwise, I think this is a very good solution! Keep up the good work and keep on coding! Kudos!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub