React + Tailwind CSS Solution - fully interactive! INTERVIEW PROBLEM?

Community feedback

• 

  Amélie•330

  @aweliego

  Posted almost 3 years ago

  Hi Kyle!

  I can't speak to Tailwind, but as far as I can tell, you did a good job building this app with React! I also liked that project, very simple in appearance but makes you revisit a lot of frequently used functionalities indeed. Like you, I found it a bit frustrating to see the difference between the dimensions of my solution and those of the design after submitting my solution, but then again, it is in my opinion not crucial to the quality of the project.

  I also enjoyed reading your README by the way. It was interesting to read your thought process about the challenge and what you learned :)

  Upon testing your solution I wanted to share with you the following suggestions/feedback:

  • I would give the 'cursor' property a value of 'pointer' for the rating and submit buttons, so it's clear that these are clickable elements.
  • If I submit without having selected a score, I get a 'You selected 0 out of 5', which makes sense since the rating state is initialised with 0. I suppose this is not the intended behaviour, so it would be nice to have some logic to prevent that from happening. [I am totally cheating a bit here, because I also just submitted my solution on this challenge yesterday and someone pointed out to me that my rating is 'undefined' when clicking Submit without selecting a rating - so I'm just passing this very good feedback around I guess 😆]

  And as part of your continued development, why not add some transition when switching from the rating component to the thank you card? :)

  Well done again! 👏

  30