React, TailwindCSS

Community feedback

• 

  S MD suleman•3,510

  @sulemaan7070

  Posted over 2 years ago

  hey Tobi Idowu😄, great job on completing the challenge...

  1.I see that you have made the mobile-menu absolutely positioned but the user can open the menu and scroll.. and it will go up.. to tackle that issue you can use the position:fixed property.

  2.you can make the header or nav bar sticky.. so that it stays stuck on the top on the mobile version..

  Happy coding👍🏻💯✅

  10
• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div id="root"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00