bunee• 2,060
@buneeIsSlo
Posted
Hey! @Ibrohim2001, You've done really well for someone new to React. I am a beginner myself and here are a few things I think you could improve:
-
You didn't need to create the divider. FEM has provided a divider pattern as an SVG(in your
imgdirectory), you're better off using that. -
Your app will not generate any advice on Firefox. This happens because of the default caching behavior on all browsers. You can fix this by adding
fetch(API_URL, { cache: 'no-cache' } )in your fetch method. -
Initally your advice card is empty on load. It is good practice to set temporary placeholders, rather than empty strings.
Hope this helps :)
1
