Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

ReactJs with Styled Components, Mobile First, Flex and Grid.

Nikolas Matias•65
@NikolasMatias
A solution to the Blogr landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


A lot of what I did is in my readme, but anyway I still want to ask somethings.

What do you think about the way I'm handling with the Theme? I think it's the start of a scalable theme managment. But... at the same time I'm not liking the way I organized the colors. Any tip?

I would like to ask for better ways to deal with the images of the sections bellow the header. I'm used position absolute in their case but I'm sure it's not the best way to deal with it.

I also had some difficult in the blue section. Cause inside it we have an image in background but it's different from the original and I trully don't know how could I make it looks equal.

I had some problems with the menu. I don't know if the hover effect is the better one for this case. And i'm still thinking about the Mobile Menu Dropdown. I still think it coul be better. But even so, I'm proud of it, cause I think I did a good job with this Dropdown.

Now thinking about my own architecture. What do you think about the way I used the Components and the Styled Components? I get this architecture in part cause of one of my friends. He use it this way and I thought it could be a good idea.

Besides all of it, any tips? I really want to improve even more.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Yevgeny•210
    @YevgeniyMakkaveev
    Posted almost 4 years ago

    I don't know if it is a good idea or not, but i use one class just for the geometry, and make another style for the color. With it you can make just one file for the color that will apply to all app and you don't have to pass color props too all your components. It works for me in Sass, but i think it will work fine without it even on pure css. But I came here just to learn css tricks, so I am curious too about the right way. Also you may want to close the previous menu on a header when you open the other, but I guess it’s just me, who don’t like to open many things at the same time. The layout is readable even with all of the tabs open. And thanks for an example how style components and typescript work! Good luck and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub