Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

react+tailwind

P
Feng•380
@niuguy
A solution to the Tip calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Lovro Peraić•400
    @loki-pepe
    Posted 5 months ago

    I can't really judge your HTML and CSS as the app was written using tools I'm not acquainted with, but the good thing is the page is responsive and handles varied font-size settings well.

    As for the app itself, the visuals are a bit off, and more importantly, it is a bit buggy:

    • the calculator should be empty by default
    • there should be error messages for different errors:
      • the inputs probably shouldn't accept negative numbers
      • the bill input probably shouldn't accept a number with more than two decimals (there are only 100 cents in a dollar)
    • for some reason the inputs delete their content when I try to put a non-number into them (apart from the custom tip input). This is a bad user experience. The input should probably allow an invalid character, but then show an error message (or at the very least, not delete the valid input).

    Generally, try and keep true to the original design and always try to think about ways a user might use (and break) your app. A few CSS tweaks and a few more lines of JavaScript would greatly help your app. Keep at it!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub