Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

recipe page

jonathan•50
@jonathansm973
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

pude terminarlo pero puedo mejorar el codigo

What challenges did you encounter, and how did you overcome them?

el ultimo bloque pensaba que era una tabla y me complique mucho pero despues encontre una solucion con los bordes

What specific areas of your project would you like help with?

a simplificar un poco mas el codigo

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Ruben•390
    @RuxCastillo
    Posted 9 months ago

    Hola Jonathan, ¿cómo estás? Espero que bien. Después de revisar tu código y el preview, pude ver que pusiste mucho esfuerzo en tu trabajo y realmente hiciste un buen trabajo haciéndolo legible y fiel a la página. Solo quería mencionarte algunas cosas que noté y que podrían ayudarte. Observé que la tabla de abajo la hiciste con div y p tags, y creo que podrías haber logrado el mismo resultado con table, th y tr tags, haciendo así tu código más semántico y evitando la "divitis". También noté que solo realizaste la versión para celular y no utilizaste @media para crear las versiones de tablet y PC, lo que hace que la screenshot quede desubicada. Pero puedo ver que pusiste un gran esfuerzo en hacer tu código muy detallado y fiel a la versión original. Espero verte más por aquí, es bueno encontrar a otras personas que hablan español. ¡Hiciste un gran trabajo! Saludos.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub