Skip to content
Submitted 12 months ago

recipe page with A lot of semantic html

f1r3•140
@f1r3place
A solution to the Recipe page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I love how it behaves at different sizes, just looks and feels awesome

While I would rather not deal with lists ever again in my life, I could probably make the unordered lists look decent using only the ::marker pseudo-element instead of ::before like I did

What challenges did you encounter, and how did you overcome them?

The padding on the lists just did not want to work, at all. Had to look it up, and found a whole article on marker behavior with padding, so that helped

Code

Please log in to post a comment

Log in

Community feedback

  • Roberts P•120
    @indaqoo

    Hi @f1r3place

    Project looks solid, html is decent, but you could improve some thing about css.

    The current CSS class .container can be improved by separating it into two distinct classes: .container and .card. This approach enhances modularity and reusability.

    Instead of adding a border on an element for horizontal line you could use <hr> element and style it accordingly.

    hr {
    height: 1px;
    background-color: var(--stone-150);
    border: none;
}

    Looks like you are making a lot of flex box container where they are not really needed. since you can apply margin bottom to the heading. and If you could rename divs to sections it would be easy to contorl that

    section > h2 {
    font-family: 'Young Serif', serif;
    font-weight: 400;
    font-size: 1.75rem;
    margin-bottom: var(--size-300);
    color: var(--brown-800);
}

    This is how I styled my lists:

    ul, ol {
    padding-left: var(--size-300);
}

ol li::marker, ul li::marker {
    color: var(--brown-800);
}

ol > li::marker {
    font-weight: 500;
}

li {
    margin-bottom: var(--size-100);
    padding-left: var(--size-200);
}

    There is also some differences in font weights from the design

    Usefull video for lists:

    Marked as helpful
  • Yasser Harzelli•80
    @ItsYasser

    good job, header could be less bold

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord