Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

RECIPE PROJECT

sass/scss
P
Enziu•100
@DefinitelyNotPatrick
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am most proud of the use of the grid along with the flex and the imagination I was able to use. Next time I won't make mistakes like I noticed now such as elements that repeat and I could have created a common class for them

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • MrLanter•220
    @MrLanter
    Posted 10 months ago

    Hello, this project is really great, and I appreciate the effort that went into it, congratulations!

    I could just recommend you to split the main.scss file into several files and then import them all from main.scss. This method of doing would allow a better readability and maintenance of the code.

    I also noticed a part of your code quite repetitive which is a problem for maintenance, accessibility, and for the speed to write the code:

    &--one::before {
       content: '1.';
    }
    &--two::before {
       content: '2.';
    }
    &--three::before {
       content: '3.';
    }
    &--four::before {
       content: '4.';
    }
    &--five::before {
       content: '5.';
    }
    &--six::before {
       content: '6.';
    }
    

    The best solution I can suggest is to leave list-style visible for both ol and ul and change the styles by doing

    li::marker {
            color: $myFavoriteColor;
            font-size: 1rem;
    }
    

    I also noticed that you put an alt for the image, which is good but I think its content could be shorter because it can be truncated.

    You imported the text fonts from google fonts only there is already a folder that contains the fonts and I think it would be better to import them from here.

    @font-face {
        font-family: 'font-name';
        src: url('url') format('truetype'); /* format value depends on the file format */
        font-weight: 400;
        font-style: normal;
    }
    

    I hope this really helped you, I wish you good luck, bye!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub