Fraser Watt• 1,790
@fraserwat
Posted
Hey, this looks great!
Few suggestions:
- Check your <body> background colour against the one in the design. Should be one of the colors in the "README.md" file.
- I'd have your @media query kick in a bit sooner, basically as soon as it doesn't "feel" right to have it in mobile/tablet mode anymore (its as much an art as a science)
- I'd have max-widths as opposed to min-widths, the rest can be sorted out with padding
.CardContaineris redundant if you have a <main> element, that's your container.- Don't need to explicitly state margin-top if you're trying to vertically center your component. Try adding
min-height: 100vh; display: flex; flex-direction: columnto the body, then just usingmargin: autoto center your <main> component.
Looks great though, keep up the good work!
Fraser
1
