@notapatch
Posted
I have not done this challenge. Your site looks the same, but just offset? I don't think it's important unless you don't know how to make the offset the same.
I liked:
- CSS variables.
- CSS was written consistently - I assume you used a linter or experienced.
- BEM ? usage (I don't write CSS much now, but as long as you have a system that works for you)
The only thing I would not be sure about is that usage of colors in naming the cards. My thoughts would be to name it after the type of cars instead because the chances of the car type changing is less than the chance the designer wants to change the colors.
.card--orange { ===> .card--sedan ???
background-color: var(--orange);
border-top-left-radius: 10px;
border-top-right-radius: 10px;
}
Marked as helpful