@correlucas
Posted
๐พHello @ovie-best, Congratulations on completing this challenge!
Great code and great solution! Iโve few suggestions for you that you can consider adding to your code:
1.Improve your html markup using meaningful tags to wrap the content, you can replace the div youโve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.
2.Use max-width: 100%
for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).
3.Donโt use id
to give the style of your elements, it's not a good idea because id
is a too specific selector used for forms
and Javascript code. Instead, use class
for styling and let the id
for much specific stuff. It's also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.
โ๏ธ I hope this helps you and happy coding!
Marked as helpful