Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive 3-column preview challenge solution

Richardβ€’ 60

@detomdev

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


There is something going on with the attribution when in the desktop orientation. Other than that I was happy with how this turned out.

Community feedback

Vanza Setiaβ€’ 27,855

@vanzasetia

Posted

Hello there, Richard! πŸ‘‹

What is the thing that going on with the attribution on desktop view? I don't see any issue.

I notice an empty script.js file in the GitHub repository which I highly recommend removing. I might make other developers (who might be yourself in the future) wonder about it.

Also, all the icons aren't showing up because it's actually trying to find all icons on the root domain which in this case https://detomdev.github.io/. So, the full path would be https://detomdev.github.io/images/icon-sedans.svg. I recommend adding a . before the forward-slash (./) to make the start point at the current directory.

All the icons are decorative images so I suggest leaving the alt="" empty. This way, screen reader users will only listen to the page content.

That's it! I hope this information is useful! 😁

Marked as helpful

1

Vanza Setiaβ€’ 27,855

@vanzasetia

Posted

In general, you want to always put a dot before the forward slash if you plan to host the site using the GitHub page. πŸ˜‰

1
Richardβ€’ 60

@detomdev

Posted

@vanzasetia Those small details will get you every time. Thanks.

0
Vanza Setiaβ€’ 27,855

@vanzasetia

Posted

@detomdev No problem! πŸ‘

Marked as helpful

0
Moβ€’ 840

@MohamedAridah

Posted

Hello there, Richard! πŸ‘‹. Good job.

you can do simple improvements for this challenge:

  • instead of using border-radius separately for .sedans and .luxury divs and change them again by mediaquery. You can set border-radius just for the .container and everything will work fine.
	.container {
		border-radius: 10px;
		overflow: hidden; /* to crop radius perfectly */
	}
  • For active state for button elements. you can change cursor of the mouse to pointer to inform user this is clickable
	button:hover{
		cursor: pointer;
	}
  • To be more HTML Semantic you can use <footer> element instead of .attribution div.

I hope this wasn't too long for you, hoping also it was useful😍.

Goodbye and have a nice day.

Keep codingπŸš€

Marked as helpful

0

Richardβ€’ 60

@detomdev

Posted

@MohamedAridah thank you for the tips!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord