@vanzasetia
Posted
Hello there, Richard! π
What is the thing that going on with the attribution on desktop view? I don't see any issue.
I notice an empty script.js
file in the GitHub repository which I highly recommend removing. I might make other developers (who might be yourself in the future) wonder about it.
Also, all the icons aren't showing up because it's actually trying to find all icons on the root domain which in this case https://detomdev.github.io/. So, the full path would be https://detomdev.github.io/images/icon-sedans.svg. I recommend adding a .
before the forward-slash (./
) to make the start point at the current directory.
All the icons are decorative images so I suggest leaving the alt=""
empty. This way, screen reader users will only listen to the page content.
That's it! I hope this information is useful! π
Marked as helpful
@vanzasetia
Posted
In general, you want to always put a dot before the forward slash if you plan to host the site using the GitHub page. π
@detomdev
Posted
@vanzasetia Those small details will get you every time. Thanks.
@vanzasetia
Posted
@detomdev No problem! π
Marked as helpful