@vanzasetia
Posted
š Hi Elvinas!
š Congratulations on finishing this challenge! I have some feedback on this solution:
- Accessibility
- š Well done on taking care of those images.
- š Good job on making all the page content live inside the main landmark.
- The
Reliable, efficient delivery Powered by Technology
text only makes sense if read as one sentence. So, you can wrap the text withh1
.
<h1>
<span class="heading__top">Reliable, efficient delivery</span>
Powered by Technology
</h1>
Note: You can make the span as a block element.
That way the "Powered by Technology" will
move to the next line.
- You can make the wrapper as the unordered list and wrap each item using
li
instead of usingdiv
.
<ul class="wrapper__sections">
<li class="sections__column sections__card sections__card-cyan">
<p>Supervisor</p>
<p>Monitors activity to identify project roadblocks</p>
<img src="images/icon-supervisor.svg" alt="">
</li>
...more list items
</ul>
- Also, I would recommend making the bold text as a paragraph, since the content below it is too small. The heading is commonly used as a label for
section
orarticle
. - You can think of a heading is like a title on a document.
- Styling
- Don't limit the height of the
body
element, it will not allow the users to scroll the page if the page content needs moreheight
. Usemin-height
instead.
- Don't limit the height of the
That's it! Hopefully, this is helpful!
Marked as helpful
@elvinasn
Posted
@vanzasetia Thank you!