Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive accordion

#sass/scss#bem
Kryptonβ€’ 180

@madhusudanbabar

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

Hey good job on the challenge! In the future, to avoid accessibility issues, you could use semantic tags for the direct children of your <body> or you could use role="".

So, in your case, instead of <div class= "container">, you could use <main>, and for your <div class="attribution">, you could use <footer>.

OR

You could add roles like so: <div class= "container" role="main"> and <div class="attribution" role="contentinfo">

:)

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord