Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Responsive accordion using HTML, CSS (Flexbox) and JS

accessibility
NatSolo•110
@nataliiasolomchak21
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of improving my skills in JavaScript and being able to quickly problem-solve in my mind. When I first encountered this challenge, I already had a clear idea of how I would write the JavaScript for it. This is an area where I've faced challenges in the past, so I'm particularly pleased with my progress. It's rewarding to see myself becoming more proficient in this aspect of programming

What challenges did you encounter, and how did you overcome them?

I encountered a challenge when adding keyboard event listeners. It required some research and took longer than I expected. However, I'm proud that I was able to figure it out. Despite the extra time it took, I'm pleased with the outcome and the new skill I've gained.

What specific areas of your project would you like help with?

I feel like I've written too much JavaScript code for this solution. Are there any suggestions on how to make it better and shorter? Thank you in advance :)

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grego•1,430
    @Grego14
    Posted over 1 year ago

    Hello! I have been reading the code of your challenge, and here I leave you some recommendations.

    You can use the margin-inline property to specify the margin on the left and right

    @media (min-width: 480px) {
      .accordion {
        width: 40%;
        height: 40%;
        margin-inline: auto;
      }
    }
    

    I also recommend leaving the alt attribute empty on these icons. since this is used mostly in images that have meaning on the page.

    creating the eventListener outside of the forEach loop or making use of event delegation to avoid using multiple eventListeners. Since there you are creating two for each question, click and keydown. Event Delegation Example

    I hope this helps!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub