Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive advice quote generator using javascript,css,html

ibiminaā€¢ 490

@ibimina

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


All observations noted and corrected

Any feedback will be appreciated

Thanks

Community feedback

@soewaiyanag

Posted

Great job with functionality. But with design, I found that the dice button is not fully centered. When I check your code I found that you are using a fixed value for the right property which is right: 8rem. You can fix it by setting it's right to 50% and adding transform: translateX(-50%). It will center the dice no matter what size or width of the card. And give it border-radius 50% to get a full circle. And would be better if you fix your font size and font-weight. Other than that, well done with functionality, keep it up.

Marked as helpful

0

ibiminaā€¢ 490

@ibimina

Posted

@soewaiyanag thanks for the feeddback, I made some few changes

1
P
Daveā€¢ 5,245

@dwhenson

Posted

Hey nice, job here!

To make things faster or appear faster, I would 1) move the script to the head, and add the async attribute, 2) put some placeholder text in the HTML that way if things are slow or JS fails the user still has something to read 3) not include window.onload and just execute the function as its read (you may need to swap async to defer if that messes up interactivity).

Also, I'd suggest having another look at your fonts - they don't seem to be showing up, and also adding some fallback text in your catch so that the user still sees something if JS fails for any reason.

Hope this helps a little

Cheers Dave

Marked as helpful

0

ibiminaā€¢ 490

@ibimina

Posted

@dwhenson Thanks for the feedback. I made a few changes

0
P
Daveā€¢ 5,245

@dwhenson

Posted

@ibimina Nice! The fonts look better - I think it seems a bit faster too.

0
Shashree Samuelā€¢ 9,260

@shashreesamuel

Posted

Hey good job completing this challenge

Keep up the good work

Your solution looks great however I think the font family of the content does not match the one specified in the style-guide.md file.

In terms of your accessibility issues simply wrap all your content between main tags

I hope this helps

Cheers Happy coding šŸ‘

0

ibiminaā€¢ 490

@ibimina

Posted

@TheCoderGuru thanks corrected

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord