@Comet466
Posted
Hello, Olutimilehin Olushuyi.
nice job in this challenge just a few things to point out.
-you can center the card more if you set a "hight:100vh" in the body tag
also the .hero-text its way bigger than the image, you can fix this by declaring a flex propertie like this "flex:1" in the class ".hero-text"
happy coding
@ShuyiOlutimi
Posted
@Comet466
Thank you so much!
I did try using a 100vh but I noticed it broke the design on mobile. Also, seeing that most users would use mobile first, I wasn't willing to trade off a good mobile experience for pixel perfect design. Hence, I removed it. Is there a way to ensure that the mobile view is not broken when I use a 100vh?
I will use the flex property to fix the ratio of the hero-text to the hero-image.
Thanks for your feedback!
@Comet466
Posted
@ShuyiOlutimi sure there is, just change the heigh from 100vh in the desktop media querie to auto in the mobile
@ShuyiOlutimi
Posted
@Comet466 I immediately thought of that after sending my first response. I fixed it now.