Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Responsive app | CSS Grid/Flex | JavaScript + API

accessibility, fetch
Victor Feitosa Garcia•230
@VFGarciaDev
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of using an API and sync it with JavaScript dom elements

What specific areas of your project would you like help with?

I'm open and happy to receive any suggestion!!

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Bernardo Poggioni•7,030
    @R3ygoski
    Posted about 1 year ago

    Olá Vitor, parabéns pela conclusão do seu projeto, ele ficou muito bom, e ele está perfeitamente igual ao design proposto.

    Seu HTML está impecável, semântico e bem estruturado, seu JS a mesma coisa, ele está muito bom, e seu CSS em grande parte também, eu só gostaria de recomendar uma coisa relacionada ao CSS, que é de utilizar medidas relativas para definir o tamanho dos elementos e espaçamento, como no card por exemplo, que dessa forma, se um usuário utilizar uma configuração de fonte maior, isso fará com que ele expanda algumas partes, deixando mais responsivo e aumentando a acessibilidade.

    Edit: Sobre o comentário acima (ou abaixo), que fala sobre a atributtion, não é necessário fazer isso de definir no body o position: relative, isso porque como seu attribution é absolute, e não tem nenhum parente com relative, ele vai pro parente mais próximo, que no caso é o body.

    E novamente, parabéns, seu projeto está impecável. Caso algo que eu tenha dito não tenha ficado claro, por favor, pergunte aqui embaixo que tentarei ajudar da melhor forma possível.

  • Sivaprasath•2,500
    @sivaprasath2004
    Posted about 1 year ago

    Hello, I would like to extend my congratulations on completing this challenge.

    • I will give some suggestion i believe its used for improve your skill.
    • In .attribution tag to add challenge by and coded by it's not perfect in the mobile site. Use this following code to change that will be proper work in the mobile devices.
    • HTML <body><main></main><footer><div class='attribution'></div></footer></body> change to following structure .
    • change the following CSS in your solution
    body{
    position:relative;
    }
    .attribution {
        position: absolute;
        bottom: 0;
    }
    

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub