@fraserwat
Posted
Hey, good stuff!
Would wrap the button element for the pop out menu in a <button> element. Good for accessibility, you can tab to it and it'll allow you to put a background on it.
Also look into how you can use padding to avoid having to set explicit widths. Especially when you have loads of components on the same screen, you want to be stating the exact heights and widths of things as little as possible so that everything can be responsive at different screen widths.
e.g. the "text" div (i'd have this as a class, not an id btw), if you set left and right padding here you can get rid of the explicit width and margin attributes on the header and p elements.
Keep up the good work!
Fraser
Marked as helpful
@cujothechief
Posted
@fraserwat well noted! thank you very much!
