Submitted 6 months agoA solution to the Newsletter sign-up form with success message challenge
responsive article signup page
@Belamana-Harshitha
Solution retrospective
What specific areas of your project would you like help with?
I want help in the local storage method and the error while handling the email input
Code
Please log in to post a comment
Log in with GitHubCommunity feedback
- @chanwinharold
- you should use semantics tags in your HTML
- you don't need to nest all the tags of your container in the form tag, just nest the input, the label and the button
- you don't need to create another page for the success message. Just set the display of this div to "none". if you do all in a single page using the display: none you'll be able to display the email value in the success message more easily in your form.addEventListener instead of using the local storage.
- try to review your css code for the responsiveness.
I hope this comment helps you Good Luck😉
- P@sdkdeepa
- HTML is not semantic. Please use <main>, <section> etc to make it semantic. You can take a look at this : https://www.w3schools.com/html/html5_semantic_elements.asp
- Use "alt" for images to make it accessible
- The image is not responsive for mobile and the image overflows.
Resources:
- https://utopia.fyi/
- https://www.joshwcomeau.com/css/interactive-guide-to-flexbox/
- For error message you can use css to
display: none;using the class name.
Good luck! you are in the right track.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord