@MaxTarasevich
Posted
Hi!
Good job!
I am also currently learning how to work with React, TypeScript, Scss and Tailwind.
I would like to pay your attention to the following points:
1.In the package.json file, I did not find dependencies for sass! Perhaps you will find the link to install it useful:
- Components.
Looking through your code on GitHub, I found only one component in the components folder - ExpensesChart.tsx, but in this file there was another component - BarChart, and in the App component I found another component - Attribution. I think it's a good idea to put all the components in separate files, it's much easier to read the code!
As for me, splitting the code into components is the most important and difficult part in React!
I found an interesting article about components in React, maybe you will be interested in reading:React components composition: how to get it right.
It also seems to me that each component should have its own style file, so they will become independent and self-sufficient!
I hope my feedback was helpful to you!
Marked as helpful
@shivaprakash-sudo
Posted
@MaxTarasevich
Hello!
Thank you.
Nice! How's it going so far?😀
I installed SASS globally, so I keep forgetting to add it to the dependencies😅.
Yeah, you have some good points about the component structures, I'll try to structure them better from now onwards.
Also, good point, I'll do that from now.
Thank you, it was very helpful😊.
