Responsive blog preview card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezR

  Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.
  • Consider using <h2> as a wrapper for the anchor tag for the title
  • Consider using <span> or <time> instead of paragraphs for elements that are not actual paragraphs like Learning or Published....

  CSS and Styling:

  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • The body should not have its height limited. Instead of using height: 100vh, use min-height.

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".
  • Profile image could benefit from a more descriptive alt text, like alt="Headshot of Gary Hooper".
  • Maintain semantic HTML structure by using appropriate elements for their intended purposes.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  10