Responsive Card Component using FlexBox, BEM

Solution retrospective
I'm trying to use different layout options, any ideas and feedback are welcome
Please log in to post a comment
Log in with GitHubCommunity feedback
- @PhoenixDev22
Hello Yazeed-git,
I have some suggestions:
-
You should set the
font-size
on the element usingrem
unit. Usingpx
won't allow the user to control the font size based on their needs. -
No need for any heights on this at all. All you need is a
min-height
on the half of the card containing the image. It's rarely ever a good practice to set heights on elements . Let the content dictate how tall something needs to be.
Hopefully this feedback helps.
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord