Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 2 months ago

Responsive Card design with QR Code

Shashank Gupta•40
@Shashank23codes
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Kama•110
    @Kama-ds10
    Posted 2 months ago

    Hey Shashank! Awesome work getting this QR Code component up and running 👏 I reviewed your HTML, and you're doing a great job, especially for an early-stage project. Here's a detailed breakdown of what you nailed and what you can improve:

    What You Did Well: Semantic Setup: You've used essential tags like <!DOCTYPE html>, lang="en", meta tags, and included a description. That’s solid for both accessibility and SEO.

    Google Fonts Integration: You included the Outfit font family correctly, which helps match the official design spec.

    Clean Structure: The .card div is a neat container. It keeps everything organized and readable, which is great for maintainability.

    Simple, Readable Code: Your HTML is minimal and clear — no unnecessary elements or messy nesting.

    Suggestions for Improvement: Fix Extra Closing </div>: You have an extra </div> at the bottom of your code:

    </div> <!-- This one doesn't have a matching open tag --> This will break the layout or cause rendering issues. Just delete that line.

    Final Thoughts Powerful work here, Shashank 🙌 With just a few small improvements — like semantic enhancements and better alt text — this will be a super polished beginner project. Keep building and trying new layouts — you’re progressing well!

    Marked as helpful
  • justcallmeea•70
    @justcallmeea
    Posted 2 months ago
    • I personally struggle to write README documents, and after going through this user's document, it was very enlightening.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub