Shashi Lo• 1,345
@shashilo
Posted
Hey Natalia. This looks pretty good, but I did notice some details that could improve your solution:
- Paying attention to the details. What I mean is looking at the fonts, line height, shadows, spacing, etc. When you work with a designer, they will be very picky with you implementing it almost pixel perfect.
- Because you are utilizing Bootstrap, look into the available components it comes with already. One example is the button.
- The naming convention could improve. If you are follow BEM, I don't see a Block called out.
card__component
could be a block ascard-component
. Then anything that is an Element could follow. - The proceed and cancel links do not have hover states. This is because there is not a href for them.
1
NataliaTg• 35
@NataliaTg
Posted
@shashilo Thank you so much Shashi!! I will work on those details :)
0