Really nice work here!
Personally, I don't think those icons are meaningful, so would aria hide them but that's just my preference.
And those links shouldn't be role button.
The rest is great!
@folathecoder
Posted
@grace-snow Hi Grace! 👍
Do you mind telling me when and when not to use roles, because I thought buttons need to be indicated. Why shouldn't the links be role: button?
Can you also tell me when not to add alt text on images?
Thank you!
@folathecoder role button is saying "I want these to have button semantics and be interacted with like a button" - it's saying they are triggering actions not being navigation.
As a general rule it is rare to want to change the role of a html element, as if you needed to, you'd just use that element in html in the first place.
With the images, you want them to have alt descriptions if they need to be listed and announced as meaningful content. Are they adding to the meaning of the document, or are they purely decorative? I think these images are decorative - the content's meaning would not be altered by the images being there or not, they're not bringing any real value. So I would hide them.
@folathecoder
Posted
@grace-snow Thank you Grace, you have really been a blessing in my journey as a Dev. I appreciate your effort! 👍
