Vanza Setia• 27,835
@vanzasetia
Posted
👋Hi Jakub!
Regarding to your questions:
- In this challenge you have to create the background and the illustration from complete scratch, that's why this is an intermediate challenge. If all the images has been prepared this might be a junior challenge 😁. In my opinion the two background needs to be bigger.
- The property order is matter. For instance if you do this, then the body background would be
blue
.
body {
background-color: red;
background-color: blue;
}
- OR, the property order that you mean is maybe like sorting the property based on alphabetical order? Well, I would recommend the CSS Concentric property order.
/* Alphabetical Order */
body {
background-color: red;
color: white;
display: flex;
justify-content: center;
}
- Based on CSS Guidelines, it's good to "title" your CSS for every section. But, it's not always a must to have comment.
Feedback:
- Use
rem
or sometimesem
unit instead ofpx
. It's a good practice to never usepx
most of the time, like in this case. - For any decorative images, like in all the images, you should leave the
alt=""
empty and addaria-hidden="true"
to make sure all screen readers ignore those images.
That's it! Hopefully this is helpful!
Marked as helpful
0